Skip to content

Comments

Add Cory Monty to 2019-06-06 + Dynamic variable declaration#171

Merged
leebyron merged 4 commits intographql:masterfrom
cmonty:patch-2
Jun 5, 2019
Merged

Add Cory Monty to 2019-06-06 + Dynamic variable declaration#171
leebyron merged 4 commits intographql:masterfrom
cmonty:patch-2

Conversation

@cmonty
Copy link
Contributor

@cmonty cmonty commented May 9, 2019 •
edited
Loading

@IvanGoncharov
Copy link
Member

IvanGoncharov commented May 9, 2019

@cmonty I checked graphql/graphql-spec#377 and don't see anything about "Pipeline Mutations" can you please submit issue or PR to https://github.com/graphql/graphql-spec with some details so other participants can prepare.

@cmonty cmonty changed the title Add Cory Monty to 2019-06-06 + Pipeline Mutations Add Cory Monty to 2019-06-06 + @export directive May 9, 2019
@cmonty
Copy link
Contributor Author

cmonty commented May 9, 2019 •
edited
Loading

@IvanGoncharov sorry about that! I have updated the agenda item and description as we want to talk about the @export directive in the context of nested mutations within a single operation. @lkorth may end up opening a new issue, in which case I'll update the agenda.

@IvanGoncharov
Copy link
Member

IvanGoncharov commented May 9, 2019 •
edited
Loading

@cmonty Thanks for the clarification.

leebyron
leebyron requested changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@leebyron leebyron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to try something new where we include a link to the relevant proposal from the agenda so that people can quickly click and read up before or during discussion. Would you mind including a link here?

Something like:

`@export` Directive [proposal](graphql-spec-issue-or-pr-url) [impl](graphql-js-pr-url) (30m)

@cmonty
Copy link
Contributor Author

cmonty commented May 10, 2019

@leebyron Absolutely! I'll add some links.

@cmonty cmonty changed the title Add Cory Monty to 2019-06-06 + @export directive Add Cory Monty to 2019-06-06 + Dynamic variable declaration May 10, 2019
@cmonty
Copy link
Contributor Author

cmonty commented May 10, 2019

Now relates to graphql/graphql-spec#583 and added link to the agenda

@leebyron leebyron merged commit ea7e545 into graphql:master Jun 5, 2019
@cmonty cmonty mentioned this pull request Jun 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leebyron leebyron leebyron requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmonty @IvanGoncharov @leebyron